[webkit-changes] [WebKit/WebKit] 647046: Regression(270013 at main) RELEASE_ASSERT(!m_count); ...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 647046ce608e4be46cb91c7a345572925de0d5a1
      https://github.com/WebKit/WebKit/commit/647046ce608e4be46cb91c7a345572925de0d5a1
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-11-07 (Tue, 07 Nov 2023)

  Changed paths:
    A LayoutTests/fast/text/Font-destructor-crash-expected.txt
    A LayoutTests/fast/text/Font-destructor-crash.html
    M Source/WebCore/platform/graphics/Font.h
    M Source/WebCore/platform/graphics/FontCascade.cpp
    M Source/WebCore/platform/graphics/FontCascadeFonts.cpp
    M Source/WebCore/platform/graphics/FontRanges.cpp
    M Source/WebCore/platform/graphics/GlyphPage.h
    M Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp

  Log Message:
  -----------
  Regression(270013 at main) RELEASE_ASSERT(!m_count); in WebCore::Font::~Font()
https://bugs.webkit.org/show_bug.cgi?id=264313
rdar://117847851

Reviewed by Ryosuke Niwa.

Use WeakPtr instead of CheckedPtr for the Font objects so that they get
nulled out when the font cache gets cleared.

* LayoutTests/fast/text/Font-destructor-crash-expected.txt: Added.
* LayoutTests/fast/text/Font-destructor-crash.html: Added.
* Source/WebCore/platform/graphics/Font.h:
* Source/WebCore/platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::emphasisMarkAscent const):
(WebCore::FontCascade::emphasisMarkDescent const):
(WebCore::FontCascade::drawEmphasisMarks const):
* Source/WebCore/platform/graphics/FontCascadeFonts.cpp:
(WebCore::findBestFallbackFont):
* Source/WebCore/platform/graphics/FontRanges.cpp:
(WebCore::FontRanges::glyphDataForCharacter const):
* Source/WebCore/platform/graphics/GlyphPage.h:
(WebCore::GlyphData::isValid const):

Canonical link: https://commits.webkit.org/270320@main