[webkit-changes] [WebKit/WebKit] 7ebe5b: [macOS] <input type=color> swatch is too narrow in...

Aditya Keerthi noreply at github.com
Mon Nov 6 23:16:14 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7ebe5b8e2af0e2c872c32035269679e8461c3e24
      https://github.com/WebKit/WebKit/commit/7ebe5b8e2af0e2c872c32035269679e8461c3e24
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2023-11-06 (Mon, 06 Nov 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/color-input-appearance-native-computed-style-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/color-input-appearance-native-computed-style.html
    M LayoutTests/platform/wpe/TestExpectations
    M Source/WebCore/rendering/RenderTheme.cpp

  Log Message:
  -----------
  [macOS] <input type=color> swatch is too narrow in vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=264298
rdar://118023600

Reviewed by Wenson Hsieh.

On macOS, color inputs have native styling similar to buttons. Add
`StyleAppearance::ColorWell` to the allowlist of button-like controls that
have transposed metrics for vertical writing modes.

* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/color-input-appearance-native-computed-style-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/color-input-appearance-native-computed-style.html: Added.
* LayoutTests/platform/wpe/TestExpectations:
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):

Canonical link: https://commits.webkit.org/270314@main




More information about the webkit-changes mailing list