[webkit-changes] [WebKit/WebKit] 60d419: REGRESSION (270226 at main): Profiling symbols missin...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 60d419eb1b255d40764124c7c450b1c487c7e1f7
      https://github.com/WebKit/WebKit/commit/60d419eb1b255d40764124c7c450b1c487c7e1f7
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2023-11-06 (Mon, 06 Nov 2023)

  Changed paths:
    M Source/JavaScriptCore/Configurations/BaseTarget.xcconfig
    M Source/JavaScriptCore/Configurations/libJavaScriptCore.xcconfig

  Log Message:
  -----------
  REGRESSION (270226 at main): Profiling symbols missing from JavaScriptCore.framework
https://bugs.webkit.org/show_bug.cgi?id=264297
<rdar://118023550>

Reviewed by Elliott Williams.

Defining CLANG_INSTRUMENT_FOR_OPTIMIZATION_PROFILING in
BaseTarget.xcconfig makes sure that -fprofile-instr-generate is passed
when linking JavaScriptCore.framework and when building source files
for libJavaScriptCore.a.

* Source/JavaScriptCore/Configurations/BaseTarget.xcconfig:
(CLANG_INSTRUMENT_FOR_OPTIMIZATION_PROFILING):
(CLANG_INSTRUMENT_FOR_OPTIMIZATION_PROFILING_ENABLE_LLVM_PROFILE_GENERATION):
- Move variables to here from libJavaScriptCore.xcconfig.
* Source/JavaScriptCore/Configurations/libJavaScriptCore.xcconfig:
(CLANG_INSTRUMENT_FOR_OPTIMIZATION_PROFILING):
(CLANG_INSTRUMENT_FOR_OPTIMIZATION_PROFILING_ENABLE_LLVM_PROFILE_GENERATION):
- Move variables from here to BaseTarget.xcconfig.

Canonical link: https://commits.webkit.org/270306@main