[webkit-changes] [WebKit/WebKit] 26ef6e: Drop workaround added in 270248 at main and fix the b...

Chris Dumez noreply at github.com
Mon Nov 6 17:28:16 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 26ef6e92d328cb5dd1314873b52e3f5ab1b592f6
      https://github.com/WebKit/WebKit/commit/26ef6e92d328cb5dd1314873b52e3f5ab1b592f6
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-11-06 (Mon, 06 Nov 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/RenderObject.h
    M Source/WebCore/rendering/svg/RenderSVGResourceContainer.h

  Log Message:
  -----------
  Drop workaround added in 270248 at main and fix the bug properly
https://bugs.webkit.org/show_bug.cgi?id=264279

Reviewed by Nikolas Zimmermann and Said Abou-Hallawa.

The implementation of `isSVGHiddenContainer()` was incorrect and was returning
false for RenderSVGResourceContainer types, even though RenderSVGResourceContainer
subclasses RenderSVGHiddenContainer.

Fix the isSVGHiddenContainer() implementation and drop the workaround recently
introduced in 270248 at main.

* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateAncestorDependentState):
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::isSVGHiddenContainer const):
(WebCore::RenderObject::isSVGResourceContainer const):
* Source/WebCore/rendering/svg/RenderSVGResourceContainer.h:

Canonical link: https://commits.webkit.org/270302@main




More information about the webkit-changes mailing list