[webkit-changes] [WebKit/WebKit] dc77e1: Support web accessible resources in Web Extensions.

Timothy Hatcher noreply at github.com
Mon Nov 6 16:38:52 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc77e1b0e4196b9e88040f5749b88b5bdce8bfc5
      https://github.com/WebKit/WebKit/commit/dc77e1b0e4196b9e88040f5749b88b5bdce8bfc5
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2023-11-06 (Mon, 06 Nov 2023)

  Changed paths:
    M Source/WebCore/page/UserContentURLPattern.cpp
    M Source/WebCore/page/UserContentURLPattern.h
    M Source/WebKit/Platform/cocoa/CocoaHelpers.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionURLSchemeHandlerCocoa.mm
    M Source/WebKit/UIProcess/Extensions/WebExtension.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionController.mm

  Log Message:
  -----------
  Support web accessible resources in Web Extensions.
https://webkit.org/b/246489
rdar://problem/114823315

Reviewed by Brent Fulgham.

* Source/WebCore/page/UserContentURLPattern.cpp:
(WebCore::matchesWildcardPattern): Added.
* Source/WebCore/page/UserContentURLPattern.h:
* Source/WebKit/Platform/cocoa/CocoaHelpers.mm:
(WebKit::filterObjects<NSArray>): Return nil if the input is nil.
(WebKit::filterObjects<NSDictionary>): Ditto.
(WebKit::filterObjects<NSSet>): Ditto.
(WebKit::mapObjects<NSArray>): Ditto.
(WebKit::mapObjects<NSDictionary>): Ditto.
(WebKit::mapObjects<NSSet>): Ditto.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::isWebAccessibleResource): Added.
(WebKit::WebExtension::populateWebAccessibleResourcesIfNeeded): Added.
(WebKit::WebExtension::errors): Call populateWebAccessibleResourcesIfNeeded().
(WebKit::WebExtension::isAccessibleResourcePath): Deleted.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm:
(WebKit::WebExtensionTab::matches const): Use matchesWildcardPattern instead of NSPredicate.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionURLSchemeHandlerCocoa.mm:
(WebKit::WebExtensionURLSchemeHandler::platformStartTask): Call isWebAccessibleResource.
* Source/WebKit/UIProcess/Extensions/WebExtension.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionController.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/270298@main




More information about the webkit-changes mailing list