[webkit-changes] [WebKit/WebKit] 752467: Site isolation feature flag should also enable pro...

Alex Christensen noreply at github.com
Mon Nov 6 10:55:31 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 75246703fbbf49504bc7ea5d6ae096fba181fcca
      https://github.com/WebKit/WebKit/commit/75246703fbbf49504bc7ea5d6ae096fba181fcca
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-11-06 (Mon, 06 Nov 2023)

  Changed paths:
    M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebProcessPool.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  -----------
  Site isolation feature flag should also enable process swapping on window.open
https://bugs.webkit.org/show_bug.cgi?id=264265
rdar://118006257

Reviewed by Pascoe.

Site isolation implies cross-site window.open swaps processes.

* Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::initializeWebPage):
(WebKit::ProvisionalPageProxy::didCreateMainFrame):
(WebKit::ProvisionalPageProxy::didStartProvisionalLoadForFrame):
(WebKit::ProvisionalPageProxy::didCommitLoadForFrame):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::suspendCurrentPageIfPossible):
(WebKit::WebPageProxy::shouldClosePreviousPage):
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigationInternal):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::hasRootFrames):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST):
(TestWebKitAPI::openerAndOpenedViews):
(TestWebKitAPI::enableWindowOpenPSON): Deleted.

Canonical link: https://commits.webkit.org/270278@main




More information about the webkit-changes mailing list