[webkit-changes] [WebKit/WebKit] 7413ad: [Site Isolation] Null pointer dereferences in Serv...

Charlie Wolfe noreply at github.com
Mon Nov 6 10:27:04 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7413ad1495ca6257fb26c7e3eb27864e605fa5fc
      https://github.com/WebKit/WebKit/commit/7413ad1495ca6257fb26c7e3eb27864e605fa5fc
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2023-11-06 (Mon, 06 Nov 2023)

  Changed paths:
    M Source/WebCore/page/mac/ServicesOverlayController.h
    M Source/WebCore/page/mac/ServicesOverlayController.mm

  Log Message:
  -----------
  [Site Isolation] Null pointer dereferences in ServicesOverlayController
https://bugs.webkit.org/show_bug.cgi?id=264005
rdar://117767532

Reviewed by Alex Christensen.

We should early return instead of crash when the main frame is being hosted in another process.

This probably still isn't the correct behavior and will need to be fixed later.

* Source/WebCore/page/mac/ServicesOverlayController.h:
* Source/WebCore/page/mac/ServicesOverlayController.mm:
(WebCore::ServicesOverlayController::remainingTimeUntilHighlightShouldBeShown const):
(WebCore::ServicesOverlayController::buildPhoneNumberHighlights):
(WebCore::ServicesOverlayController::buildSelectionHighlight):
(WebCore::ServicesOverlayController::mouseEvent):
(WebCore::ServicesOverlayController::handleClick):
(WebCore::ServicesOverlayController::mainFrame const): Deleted.

Canonical link: https://commits.webkit.org/270275@main




More information about the webkit-changes mailing list