[webkit-changes] [WebKit/WebKit] 3de34e: AX: Add test coverage for setting focus inside a m...

AndresGonzalezApple noreply at github.com
Mon Nov 6 09:34:41 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3de34e00862ac0bcbee6653602b0a71f8ab8ef1b
      https://github.com/WebKit/WebKit/commit/3de34e00862ac0bcbee6653602b0a71f8ab8ef1b
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2023-11-06 (Mon, 06 Nov 2023)

  Changed paths:
    A LayoutTests/accessibility/focus-inside-modal-expected.txt
    A LayoutTests/accessibility/focus-inside-modal.html
    M LayoutTests/platform/glib/TestExpectations
    M Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityNotificationHandler.cpp

  Log Message:
  -----------
  AX: Add test coverage for setting focus inside a modal dialog.
https://bugs.webkit.org/show_bug.cgi?id=263715
<rdar://problem/117530301>

Reviewed by Tyler Wilcock.

Added test to ensure we AX is tracking the focus properly when set to an input element inside a newly open modal dialog.

* LayoutTests/accessibility/focus-inside-modal-expected.txt: Added.
* LayoutTests/accessibility/focus-inside-modal.html: Added.
* LayoutTests/platform/glib/TestExpectations:

In addition the following ATSPI fix is needed for the test to pass in this platform (follow up to https://bugs.webkit.org/show_bug.cgi?id=263678):
* Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityNotificationHandler.cpp:
(WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):

Canonical link: https://commits.webkit.org/270272@main




More information about the webkit-changes mailing list