[webkit-changes] [WebKit/WebKit] 8d5247: [WebGPU] Error opening https://threejs.org/example...

Tadeu Zagallo noreply at github.com
Mon Nov 6 02:06:22 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8d5247e667b6ebf6d84297d0bc9b4b55aca0d221
      https://github.com/WebKit/WebKit/commit/8d5247e667b6ebf6d84297d0bc9b4b55aca0d221
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-11-06 (Mon, 06 Nov 2023)

  Changed paths:
    M Source/WebGPU/WGSL/ConstantFunctions.h
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
    M Source/WebGPU/WGSL/tests/valid/overload.wgsl

  Log Message:
  -----------
  [WebGPU] Error opening https://threejs.org/examples/?q=webgpu#webgpu_backdrop_area
https://bugs.webkit.org/show_bug.cgi?id=264143
rdar://117893591

Reviewed by Mike Wyrzykowski.

Metal's `distance` function doesn't support floats as arguments (only vectors),
so `distance(a: float, b: float)` must be translate to `a - b `.

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::emitDistance):
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/tests/valid/overload.wgsl:

Canonical link: https://commits.webkit.org/270259@main




More information about the webkit-changes mailing list