[webkit-changes] [WebKit/WebKit] d23e04: Make ::backdrop inherit from parent element

Commit Queue noreply at github.com
Sun Nov 5 08:33:58 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d23e04b12f7944b899fc46f1abba89e300c2887d
      https://github.com/WebKit/WebKit/commit/d23e04b12f7944b899fc46f1abba89e300c2887d
  Author: Keith Cirkel <webkit at keithcirkel.co.uk>
  Date:   2023-11-05 (Sun, 05 Nov 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/dialog-backdrop-create.html
    M Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp
    M Source/WebCore/style/StyleTreeResolver.cpp

  Log Message:
  -----------
  Make ::backdrop inherit from parent element
https://bugs.webkit.org/show_bug.cgi?id=263834

Reviewed by Tim Nguyen.

StyleTreeResolver/RenterTreeUpdate explicitly checked for ::backdrop
elements to remove their inheritance chain, per the spec at the time.
https://github.com/whatwg/fullscreen/issues/124 was created to query
this and it was resolved that ::backdrop _should_ inherit.

This commit addresses the change by removing the check in
StyleTreeResolve to allow ::backdrop to inherit from its parent element,
and altering the check in RenderTreeUpdate to call renderer.style()
instead of renderer.view.style(). This aligns behaviour with the other
browsers and WPT.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/dialog-backdrop-create.html:
* Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:
(WebCore::RenderTreeUpdater::GeneratedContent::updateBackdropRenderer):
* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::makeResolutionContextForPseudoElement):

Canonical link: https://commits.webkit.org/270246@main




More information about the webkit-changes mailing list