[webkit-changes] [WebKit/WebKit] 1f9b90: Regression(270013 at main): Crash when loading bgtime.tv

Chris Dumez noreply at github.com
Fri Nov 3 10:58:00 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1f9b90609d2f001661daeefd7ea87d548dfe3fdc
      https://github.com/WebKit/WebKit/commit/1f9b90609d2f001661daeefd7ea87d548dfe3fdc
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-11-03 (Fri, 03 Nov 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/GlyphPage.h

  Log Message:
  -----------
  Regression(270013 at main): Crash when loading bgtime.tv
https://bugs.webkit.org/show_bug.cgi?id=264132
<rdar://117882210>

Reviewed by Brent Fulgham.

270013 at main updated `GlyphPage::m_font` to be a CheckedPtr. However, the
assertion is the CanMakeCheckedPtrBase destructor is hitting when loading
bgtime.tv. As a result, I am downgrading to a simple WeakPtr to address
the crash.

* Source/WebCore/platform/graphics/GlyphPage.h:
(WebCore::GlyphPage::glyphDataForIndex const):
(WebCore::GlyphPage::font const):

Canonical link: https://commits.webkit.org/270190@main




More information about the webkit-changes mailing list