[webkit-changes] [WebKit/WebKit] f7cead: [WebGPU] makeRenderBundleICBWithResources has a ty...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f7cead5304675fc162dcbc96469aafbaa30ac366
      https://github.com/WebKit/WebKit/commit/f7cead5304675fc162dcbc96469aafbaa30ac366
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-11-03 (Fri, 03 Nov 2023)

  Changed paths:
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm

  Log Message:
  -----------
  [WebGPU] makeRenderBundleICBWithResources has a typo preventing correct generation of render bundles
https://bugs.webkit.org/show_bug.cgi?id=264080
<radar://117833625>

Reviewed by Tadeu Zagallo and Dan Glastonbury.

While working through the CTS, I noticed two small typos in
RenderBundleEncoder leading to wrong usage being specified for resources
and also the list of commands was not getting completely cleared.

* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::makeRenderBundleICBWithResources):
Fix typo.

(WebGPU::RenderBundleEncoder::endCurrentICB):
Fix off by one.

(WebGPU::RenderBundleEncoder::executePreDrawCommands):
Correct dynamic offsets for fragment stage.

(WebGPU::RenderBundleEncoder::drawIndirect):
This doesn't use the index buffer, it is wrong to check the length.

(WebGPU::RenderBundleEncoder::finish):
Vector should not be cleared until bundle is created.

Canonical link: https://commits.webkit.org/270163@main