[webkit-changes] [WebKit/WebKit] f1ab7f: [JSC] Fix LocaleIDBuilder::setKeywordValue by lett...

Commit Queue noreply at github.com
Thu Nov 2 16:52:17 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f1ab7fe7c2dec3f5cadbc42bc138a946aa8070fc
      https://github.com/WebKit/WebKit/commit/f1ab7fe7c2dec3f5cadbc42bc138a946aa8070fc
  Author: Yijia Huang <yijia_huang at apple.com>
  Date:   2023-11-02 (Thu, 02 Nov 2023)

  Changed paths:
    A JSTests/stress/intl-locale-exceptions.js
    M Source/JavaScriptCore/runtime/IntlLocale.cpp

  Log Message:
  -----------
  [JSC] Fix LocaleIDBuilder::setKeywordValue by letting the callers to handle U_SUCCESS
https://bugs.webkit.org/show_bug.cgi?id=264105
rdar://117548205

Reviewed by Yusuke Suzuki.

In LocaleIDBuilder::setKeywordValue, the status may ended with
U_INTERNAL_PROGRAM_ERROR. We should let the callers to handle
the success of setKeywordValue.

* JSTests/stress/intl-locale-exceptions.js: Added.
(shouldThrow):
* Source/JavaScriptCore/runtime/IntlLocale.cpp:
(JSC::LocaleIDBuilder::setKeywordValue):
(JSC::IntlLocale::initializeLocale):

Canonical link: https://commits.webkit.org/270149@main




More information about the webkit-changes mailing list