[webkit-changes] [WebKit/WebKit] 3666f2: WebKit Cursor Pulsing is too slow while dictating

mwyrzykowski noreply at github.com
Thu Nov 2 13:59:35 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3666f20911e03c5ffeeebaaec35cb2a0e303b92b
      https://github.com/WebKit/WebKit/commit/3666f20911e03c5ffeeebaaec35cb2a0e303b92b
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-11-02 (Thu, 02 Nov 2023)

  Changed paths:
    M Source/WebCore/platform/DictationCaretAnimator.cpp

  Log Message:
  -----------
  WebKit Cursor Pulsing is too slow while dictating
https://bugs.webkit.org/show_bug.cgi?id=264061
<radar://111583491>

Reviewed by Aditya Keerthi.

Refine the animation so it matches Messages.

* Source/WebCore/platform/DictationCaretAnimator.cpp:
(WebCore::keyframe):
Decouple the pulse speed from the animation rate.

(WebCore::DictationCaretAnimator::updateAnimationProperties):
The initial pulse is shorter in Messages, shorten it in WebKit to match.

(WebCore::DictationCaretAnimator::expandedCaretRect const):
Adjust how much the cursor expands during the initial pulse animation.

Canonical link: https://commits.webkit.org/270138@main




More information about the webkit-changes mailing list