[webkit-changes] [WebKit/WebKit] 2c09c0: Web Inspector: Network tab drop zone activates inc...

mirnovov noreply at github.com
Thu Nov 2 08:31:01 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2c09c005dd59294f1251a0007ab1e9522717235c
      https://github.com/WebKit/WebKit/commit/2c09c005dd59294f1251a0007ab1e9522717235c
  Author: novov <anon185441 at gmail.com>
  Date:   2023-11-02 (Thu, 02 Nov 2023)

  Changed paths:
    M Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.js
    M Source/WebInspectorUI/UserInterface/Views/NetworkResourceDetailView.js
    M Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js

  Log Message:
  -----------
  Web Inspector: Network tab drop zone activates incorrectly
https://bugs.webkit.org/show_bug.cgi?id=260251

Reviewed by Devin Rousso.

This PR fixes a drop zone related issues caused by ImageResourceContentView being in NetworkTabContentView.
When dragging an item in when the image preview is active, both the HAR and Local Override drop zones activate, so modify DropZoneView so only one drop zone ever activates at a time.

Combined changes:
* Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.js:
(WI.ImageResourceContentView.prototype.contentAvailable):
* Source/WebInspectorUI/UserInterface/Views/NetworkResourceDetailView.js:
(WI.NetworkResourceDetailView.prototype.showContentViewForIdentifier):
(WI.NetworkResourceDetailView):
* Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js:
(WI.ResourceClusterContentView.prototype._contentViewForResourceType):

Canonical link: https://commits.webkit.org/270108@main




More information about the webkit-changes mailing list