[webkit-changes] [WebKit/WebKit] cfc4a2: Fixes for build --minimal

Philip Chimento noreply at github.com
Thu Nov 2 00:28:20 PDT 2023 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cfc4a23cc201b67e7023ffd34cdb1245ac4a60b3
      https://github.com/WebKit/WebKit/commit/cfc4a23cc201b67e7023ffd34cdb1245ac4a60b3
  Author: Philip Chimento <pchimento at igalia.com>
  Date:   2023-11-02 (Thu, 02 Nov 2023)

  Changed paths:
    M Source/WebCore/Modules/WebGPU/GPUExternalTextureDescriptor.h
    M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUExternalTextureDescriptor.h
    M Source/WebCore/bindings/js/JSWorkletGlobalScopeBase.h
    M Source/WebCore/dom/CDATASection.cpp
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/IdTargetObserverRegistry.h
    M Source/WebCore/dom/NamedNodeMap.h
    M Source/WebCore/dom/ScriptedAnimationController.h
    M Source/WebCore/editing/AlternativeTextController.cpp
    M Source/WebCore/editing/DictationCommand.cpp
    M Source/WebCore/editing/SpellingCorrectionCommand.h
    M Source/WebCore/editing/SplitTextNodeCommand.cpp
    M Source/WebCore/editing/VisibleSelection.cpp
    M Source/WebCore/editing/VisibleUnits.cpp
    M Source/WebCore/html/CheckboxInputType.cpp
    M Source/WebCore/html/HiddenInputType.cpp
    M Source/WebCore/html/SubmitInputType.cpp
    M Source/WebCore/html/parser/HTMLSrcsetParser.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
    M Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp
    M Source/WebCore/loader/archive/Archive.cpp
    M Source/WebCore/loader/cache/CachedResourceLoader.cpp
    M Source/WebCore/page/DOMWindow.cpp
    M Source/WebCore/page/LocalDOMWindow.cpp
    M Source/WebCore/page/Navigation.cpp
    M Source/WebCore/page/NavigationDestination.cpp
    M Source/WebCore/page/NavigationHistoryEntry.cpp
    M Source/WebCore/platform/glib/UserAgentQuirks.cpp
    M Source/WebCore/rendering/MarkedText.cpp
    M Source/WebCore/rendering/RenderFileUploadControl.cpp
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/RenderLayerModelObject.cpp
    M Source/WebCore/rendering/RenderReplaced.cpp
    M Source/WebCore/rendering/RenderThemeAdwaita.cpp
    M Source/WebCore/rendering/TextBoxPainter.cpp
    M Source/WebCore/rendering/TransformOperationData.cpp
    M Source/WebCore/rendering/style/WillChangeData.cpp
    M Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp
    M Source/WebCore/rendering/svg/RenderSVGResourceClipper.h
    M Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp
    M Source/WebCore/rendering/svg/RenderSVGResourceContainer.h
    M Source/WebCore/rendering/svg/SVGRenderSupport.cpp
    M Source/WebCore/rendering/svg/SVGResources.cpp
    M Source/WebCore/svg/SVGClipPathElement.cpp
    M Source/WebCore/testing/InternalSettings.cpp
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp
    M Source/WebKit/NetworkProcess/NetworkProcess.h
    M Source/WebKit/NetworkProcess/NetworkSession.h
    M Source/WebKit/Platform/IPC/Encoder.h
    M Source/WebKit/Shared/API/APICaptionUserPreferencesTestingModeToken.h
    M Source/WebKit/Shared/API/glib/WebKitContextMenu.cpp
    M Source/WebKit/Shared/API/glib/WebKitContextMenuActions.cpp
    M Source/WebKit/Shared/API/glib/WebKitContextMenuActionsPrivate.h
    M Source/WebKit/Shared/API/glib/WebKitContextMenuItem.cpp
    M Source/WebKit/Shared/API/glib/WebKitContextMenuItemPrivate.h
    M Source/WebKit/Shared/API/glib/WebKitContextMenuPrivate.h
    M Source/WebKit/Shared/glib/WebContextMenuItemGlib.cpp
    M Source/WebKit/Shared/glib/WebContextMenuItemGlib.h
    M Source/WebKit/UIProcess/API/glib/WebKitContextMenuClient.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitContextMenuClient.h
    M Source/WebKit/UIProcess/API/glib/WebKitPointerLockPermissionRequest.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
    M Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp
    M Source/WebKit/UIProcess/API/gtk/PageClientImpl.h
    M Source/WebKit/UIProcess/API/gtk/WebKitColorChooser.cpp
    M Source/WebKit/UIProcess/API/gtk/WebKitColorChooser.h
    M Source/WebKit/UIProcess/API/gtk/WebKitColorChooserRequest.cpp
    M Source/WebKit/UIProcess/API/gtk/WebKitColorChooserRequestPrivate.h
    M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
    M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBasePrivate.h
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
    M Source/WebKit/UIProcess/RemotePageProxy.h
    M Source/WebKit/UIProcess/WebProcessProxy.cpp
    M Source/WebKit/UIProcess/WebProcessProxy.h
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
    M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp
    M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp
    M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp
    M Source/WebKit/WebProcess/WebPage/EventDispatcher.h

  Log Message:
  -----------
  Fixes for build --minimal
https://bugs.webkit.org/show_bug.cgi?id=263905

Reviewed by Michael Catanzaro.

Header file additions:
These additions all seem to be cases where normally the header is
included
by another header, but when compiling with a certain feature turned off,
the header no longer gets pulled in, making some function or class used
in
the file undeclared.

This especially sometimes shows up as linker errors, when a
"FooInlines.h"
header doesn't get pulled in, and an inline function is declared in the
regular "Foo.h" header but its body is never included.

These all show up as compiler or linker errors when building WebKit with
--minimal.

In some cases, remove a forward declaration since we do actually need to
include its header.

Preprocessor guards:

These changes fix builds with various options set by --minimal, such as
--no-video, --no-layer-based-svg-engine, --no-context-menus, etc.

In some cases, add UNUSED_PARAM to fix a warning that only occurs with
--no-video. In other cases, these changes fix compile errors.

Note that ENABLE_MODERN_MEDIA_CONTROLS is also switched off if
ENABLE_VIDEO is off.

* Source/WebCore/Modules/WebGPU/GPUExternalTextureDescriptor.h:
(WebCore::GPUExternalTextureDescriptor::convertToBacking const):
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUExternalTextureDescriptor.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
* Source/WebCore/bindings/js/JSWorkletGlobalScopeBase.h:
* Source/WebCore/dom/CDATASection.cpp:
* Source/WebCore/dom/ContentVisibilityDocumentState.cpp:
* Source/WebCore/dom/CustomElementRegistry.h:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::urlForBindings const):
* Source/WebCore/dom/DocumentFontLoader.cpp:
* Source/WebCore/dom/DocumentMarkerController.cpp:
* Source/WebCore/dom/IdTargetObserverRegistry.h:
* Source/WebCore/dom/NamedNodeMap.h:
* Source/WebCore/dom/PendingScript.h:
* Source/WebCore/dom/ScriptedAnimationController.h:
* Source/WebCore/editing/AlternativeTextController.cpp:
* Source/WebCore/editing/DictationCommand.cpp:
* Source/WebCore/editing/SpellingCorrectionCommand.h:
* Source/WebCore/editing/SplitTextNodeCommand.cpp:
* Source/WebCore/editing/VisibleSelection.cpp:
* Source/WebCore/editing/VisibleUnits.cpp:
* Source/WebCore/history/CachedPage.cpp:
* Source/WebCore/html/CheckboxInputType.cpp:
* Source/WebCore/html/HiddenInputType.cpp:
* Source/WebCore/html/SubmitInputType.cpp:
* Source/WebCore/html/parser/HTMLSrcsetParser.cpp:
* Source/WebCore/html/parser/HTMLSrcsetParser.h:
* Source/WebCore/html/shadow/SwitchThumbElement.cpp:
* Source/WebCore/html/shadow/SwitchTrackElement.cpp:
* Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::Run::isContentfulOrHasDecoration):
* Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp:
(WebCore::Layout::TextOnlySimpleLineBuilder::isEligibleForSimplifiedTextOnlyInlineLayout):
* Source/WebCore/loader/archive/Archive.cpp:
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::updateRequestAfterRedirection):
* Source/WebCore/page/DOMWindow.cpp:
* Source/WebCore/page/LocalDOMWindow.cpp:
* Source/WebCore/page/LocalFrame.cpp:
* Source/WebCore/page/Navigation.cpp:
* Source/WebCore/page/NavigationDestination.cpp:
* Source/WebCore/page/NavigationHistoryEntry.cpp:
* Source/WebCore/platform/glib/UserAgentQuirks.cpp:
* Source/WebCore/platform/graphics/FontMetrics.h:
* Source/WebCore/rendering/LayoutRepainter.cpp:
* Source/WebCore/rendering/MarkedText.cpp:
* Source/WebCore/rendering/RenderFileUploadControl.cpp:
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintSVGResourceLayer):
(WebCore::RenderLayer::setupClipPath):
* Source/WebCore/rendering/RenderLayerModelObject.cpp:
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::isVideoWithDefaultObjectSize):
* Source/WebCore/rendering/RenderThemeAdwaita.cpp:
* Source/WebCore/rendering/TextBoxPainter.cpp:
* Source/WebCore/rendering/TransformOperationData.cpp:
(WebCore::TransformOperationData::TransformOperationData):
* Source/WebCore/rendering/style/WillChangeData.cpp:
(WebCore::WillChangeData::createsContainingBlockForOutOfFlowPositioned const):
* Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp:
* Source/WebCore/rendering/svg/RenderSVGResourceClipper.h:
* Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp:
* Source/WebCore/rendering/svg/RenderSVGResourceContainer.h:
* Source/WebCore/rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::paintSVGClippingMask):
* Source/WebCore/rendering/svg/SVGResources.cpp:
(WebCore::SVGResources::buildCachedResources):
* Source/WebCore/svg/SVGClipPathElement.cpp:
* Source/WebCore/testing/InternalSettings.cpp:
(WebCore::InternalSettings::setShouldDeactivateAudioSession):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::isMonitoringWirelessRoutes const):
(WebCore::Internals::setIsPlayingToAutomotiveHeadUnit):
* Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp:
(WebCore::ServiceWorkerThreadProxy::setInspectable):
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/NetworkSession.h:
* Source/WebKit/Platform/IPC/Encoder.h:
* Source/WebKit/Shared/API/APICaptionUserPreferencesTestingModeToken.h:
* Source/WebKit/Shared/API/glib/WebKitContextMenu.cpp:
* Source/WebKit/Shared/API/glib/WebKitContextMenuActions.cpp:
* Source/WebKit/Shared/API/glib/WebKitContextMenuActionsPrivate.h:
* Source/WebKit/Shared/API/glib/WebKitContextMenuItem.cpp:
(webkit_context_menu_item_new):
(webkit_context_menu_item_new_from_gaction):
(webkit_context_menu_item_new_from_stock_action):
(webkit_context_menu_item_new_from_stock_action_with_label):
(webkit_context_menu_item_new_with_submenu):
(webkit_context_menu_item_new_separator):
(webkit_context_menu_item_get_action):
(webkit_context_menu_item_get_gaction):
(webkit_context_menu_item_get_stock_action):
(webkit_context_menu_item_is_separator):
(webkit_context_menu_item_set_submenu):
(webkit_context_menu_item_get_submenu):
* Source/WebKit/Shared/API/glib/WebKitContextMenuItemPrivate.h:
* Source/WebKit/Shared/API/glib/WebKitContextMenuPrivate.h:
* Source/WebKit/Shared/glib/WebContextMenuItemGlib.cpp:
* Source/WebKit/Shared/glib/WebContextMenuItemGlib.h:
* Source/WebKit/UIProcess/API/glib/WebKitContextMenuClient.cpp:
* Source/WebKit/UIProcess/API/glib/WebKitContextMenuClient.h:
* Source/WebKit/UIProcess/API/glib/WebKitPointerLockPermissionRequest.cpp:
(webkit_permission_request_interface_init):
(webkitPointerLockPermissionRequestDispose):
* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewConstructed):
(webkit_web_view_save):
(webkit_web_view_save_to_file):
* Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp:
* Source/WebKit/UIProcess/API/gtk/PageClientImpl.h:
* Source/WebKit/UIProcess/API/gtk/WebKitColorChooser.cpp:
* Source/WebKit/UIProcess/API/gtk/WebKitColorChooser.h:
* Source/WebKit/UIProcess/API/gtk/WebKitColorChooserRequest.cpp:
(webkit_color_chooser_request_get_element_rectangle):
(webkit_color_chooser_request_cancel):
* Source/WebKit/UIProcess/API/gtk/WebKitColorChooserRequestPrivate.h:
* Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseHandleMouseEvent):
(webkit_web_view_base_class_init):
(webkitWebViewBaseSynthesizeMouseEvent):
(webkitWebViewBaseSynthesizeKeyEvent):
* Source/WebKit/UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:
* Source/WebKit/UIProcess/RemotePageProxy.h:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
* Source/WebKit/UIProcess/WebProcessProxy.h:
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::updateServiceWorkerInspectability):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCreateCaptionUserPreferencesTestingModeToken):
* Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:
(webkit_web_page_class_init):
(webkitWebPageCreate):
* Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::installServiceWorker):
* Source/WebKit/WebProcess/WebCoreSupport/WebGeolocationClient.h:
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
(WebKit::DrawingAreaCoordinatedGraphics::registerScrollingTree):
(WebKit::DrawingAreaCoordinatedGraphics::unregisterScrollingTree):
* Source/WebKit/WebProcess/WebPage/EventDispatcher.h:

Canonical link: https://commits.webkit.org/270103@main

More information about the webkit-changes mailing list