[webkit-changes] [WebKit/WebKit] d31887: Unreviewed, fix iOS production builds after 270071...

Abrar Rahman Protyasha noreply at github.com
Wed Nov 1 16:56:18 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d31887d84bdcc60ea1bbeee66b1006fae4e16cb4
      https://github.com/WebKit/WebKit/commit/d31887d84bdcc60ea1bbeee66b1006fae4e16cb4
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2023-11-01 (Wed, 01 Nov 2023)

  Changed paths:
    M Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Unreviewed, fix iOS production builds after 270071 at main

Fix the following build error:
```
Undefined symbols for architecture arm64e:
  "_JSContextGetGlobalObject", referenced from:
      WTR::sendTestRenderedEvent(OpaqueJSContext*) in WPTFunctions.o
      WTR::hasTestWaitAttribute(OpaqueJSContext*) in WPTFunctions.o
  "_JSObjectMake", referenced from:
      WTR::sendTestRenderedEvent(OpaqueJSContext*) in WPTFunctions.o
  "_JSValueProtect", referenced from:
      WTR::sendTestRenderedEvent(OpaqueJSContext*) in WPTFunctions.o
  "_JSValueToBoolean", referenced from:
      WTR::hasTestWaitAttribute(OpaqueJSContext*) in WPTFunctions.o
  "_JSValueUnprotect", referenced from:
      WTR::sendTestRenderedEvent(OpaqueJSContext*) in WPTFunctions.o
  "WTR::setProperty(OpaqueJSContext const*, OpaqueJSValue*, char const*, bool)", referenced from:
      WTR::sendTestRenderedEvent(OpaqueJSContext*) in WPTFunctions.o
  "WTR::objectProperty(OpaqueJSContext const*, OpaqueJSValue*, std::initializer_list<char const*>)", referenced from:
      WTR::sendTestRenderedEvent(OpaqueJSContext*) in WPTFunctions.o

 WTR::hasTestWaitAttribute(OpaqueJSContext*) in WPTFunctions.o
  "WTR::callConstructor(OpaqueJSContext*, char const*, std::initializer_list<OpaqueJSValue const*>)", referenced from:
      WTR::sendTestRenderedEvent(OpaqueJSContext*) in WPTFunctions.o
  "WTR::call(OpaqueJSContext const*, OpaqueJSValue*, char const*, std::initializer_list<OpaqueJSValue const*>)", refe
renced from:
      WTR::sendTestRenderedEvent(OpaqueJSContext*) in WPTFunctions.o
      WTR::hasTestWaitAttribute(OpaqueJSContext*) in WPTFunctions.o
  "WTR::makeValue(OpaqueJSContext const*, char const*)", referenced from:
      WTR::sendTestRenderedEvent(OpaqueJSContext*) in WPTFunctions.o
      WTR::hasTestWaitAttribute(OpaqueJSContext*) in WPTFunctions.o
  "WTF::URL::host() const", referenced from:
      WTR::isWebPlatformTestURL(WTF::URL const&) in WPTFunctions.o
  "WTF::URL::port() const", referenced from:
      WTR::isWebPlatformTestURL(WTF::URL const&) in WPTFunctions.o
ld: symbol(s) not found for architecture arm64e
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```

...by removing `WPTFunctions.o` from the `WebKitTestRunner` binary
target. This is the correct thing to do because we pull in the symbols
in the `WPTFunctions` TU through the `WebKitTestRunnerLibrary` target
anyways, and because we don't link against WTF/JSC/etc. when building
the `WebKitTestRunner` binary on iOS.

* Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/270093@main




More information about the webkit-changes mailing list