[webkit-changes] [WebKit/WebKit] 28ea52: REGRESSION (267119 at main?): Occasional unrecognized...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 28ea5280429e1169a1de69fe994432713b6fde99
      https://github.com/WebKit/WebKit/commit/28ea5280429e1169a1de69fe994432713b6fde99
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-11-01 (Wed, 01 Nov 2023)

  Changed paths:
    M Source/WebKit/UIProcess/ios/WKWebEvent.mm

  Log Message:
  -----------
  REGRESSION (267119 at main?): Occasional unrecognized selector under -[WKWebEvent initWithEvent:]
https://bugs.webkit.org/show_bug.cgi?id=264044
rdar://117727776

Reviewed by Aditya Keerthi.

After the changes in 267119 at main, it's theoretically possible that we end up passing a
`UIPressesEvent` into `-initWithEvent:` that is not a `UIPhysicalKeyboardEvent`, but returns a non-
null `-_hidEvent` anyways.

It's unclear how this reproduces in practice, but we should be robust in this scenario by adding an
explicit class check for `UIPhysicalKeyboardEvent` before accessing methods and properties on the
event.

* Source/WebKit/UIProcess/ios/WKWebEvent.mm:
(-[WKWebEvent initWithEvent:]):

Canonical link: https://commits.webkit.org/270090@main