[webkit-changes] [WebKit/WebKit] e0e30a: REGRESSION (Sonoma): [ Sonoma wk2 Release ] compos...

Simon Fraser noreply at github.com
Wed Nov 1 15:02:31 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e0e30a6cf70ce1b26ed4ecada49ec6f2175f47ea
      https://github.com/WebKit/WebKit/commit/e0e30a6cf70ce1b26ed4ecada49ec6f2175f47ea
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-11-01 (Wed, 01 Nov 2023)

  Changed paths:
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm

  Log Message:
  -----------
  REGRESSION (Sonoma): [ Sonoma wk2 Release ] compositing/reflections/repaint-with-reflection.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=263347
rdar://117172843

Reviewed by Tim Horton.

Increase the scope of having a non-null `m_currentTransaction` in `RemoteLayerTreeContext::buildTransaction()`,
since `paintReachableBackingStoreContents()` can call `PlatformCALayerRemote::copyContentsFromLayer()` for
layers with reflections, and we need `RemoteLayerTreeContext::layerPropertyChangedWhileBuildingTransaction()`
to see `m_currentTransaction` so we mark the clone as having changed properties.

* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::buildTransaction):

Canonical link: https://commits.webkit.org/270082@main




More information about the webkit-changes mailing list