[webkit-changes] [WebKit/WebKit] 6e655d: [macOS WKTR] Enable async overflow scrolling by de...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6e655dfb81542a121845a4f664aaa0698bb307eb
      https://github.com/WebKit/WebKit/commit/6e655dfb81542a121845a4f664aaa0698bb307eb
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2023-11-01 (Wed, 01 Nov 2023)

  Changed paths:
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Tools/TestRunnerShared/TestFeatures.cpp
    M Tools/TestRunnerShared/WPTFunctions.cpp
    M Tools/TestRunnerShared/WPTFunctions.h
    M Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj
    M Tools/WebKitTestRunner/mac/TestControllerMac.mm

  Log Message:
  -----------
  [macOS WKTR] Enable async overflow scrolling by default for WPTs
https://bugs.webkit.org/show_bug.cgi?id=263810
rdar://problem/117609234

Reviewed by Tim Nguyen.

This commit enables async overflow scrolling by default for WPTs on
macOS by hardcoding enablement of the `AsyncOverflowScrollingEnabled` web
preference within `TestControllerMac` when the test runner is running
WPTs.

The heuristic for determining whether the test running is a WPT is
simply the fact that the test path is a URL and is on the ports/hosts
specified in imported/w3c/resources/config.json, as prior art from
`shouldDumpJSConsoleLogInStdErr` shows.

We keep the concept of a valid WPT URL in a separate
`isWebPlatformTestURL` helper method in WPTFunctions.h that both
`shouldDumpJSConsoleLogInStdErr` and `shouldEnableAsyncOverflowScrolling`
can consult. To get all the definitions in the right place and satisfy
the linker, this commit also touches some of target membership for WKTR.

* LayoutTests/platform/mac-wk2/TestExpectations:
* Tools/TestRunnerShared/TestFeatures.cpp:
(WTR::shouldDumpJSConsoleLogInStdErr):
* Tools/TestRunnerShared/WPTFunctions.cpp:
(WTR::isWebPlatformTestURL):
* Tools/TestRunnerShared/WPTFunctions.h:
* Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* Tools/WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::shouldEnableAsyncOverflowScrolling):
(WTR::TestController::platformSpecificFeatureDefaultsForTest const):

Canonical link: https://commits.webkit.org/270071@main