[webkit-changes] [WebKit/WebKit] f9d66b: Address some Web Extension API feedback.

Timothy Hatcher noreply at github.com
Wed Nov 1 11:44:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f9d66b7d85bbf83b21abd92449f99b8aa1448a82
      https://github.com/WebKit/WebKit/commit/f9d66b7d85bbf83b21abd92449f99b8aa1448a82
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2023-11-01 (Wed, 01 Nov 2023)

  Changed paths:
    M Source/WebKit/Shared/API/Cocoa/WKFoundation.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfiguration.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerDelegate.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMessagePort.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTab.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTabCreationOptions.h

  Log Message:
  -----------
  Address some Web Extension API feedback.
https://webkit.org/b/263908
rdar://problem/117697589

Reviewed by Brian Weinstein.

Added WK_NULLABLE_RESULT define to WKFoundation and use it in completionHandlers that can
have nil results without an error.

Also added WK_SWIFT_ASYNC_THROWS_ON_FALSE as an alias for NS_SWIFT_ASYNC_THROWS_ON_FALSE.

Adjusted some wording in the HeaderDoc comments too.

* Source/WebKit/Shared/API/Cocoa/WKFoundation.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfiguration.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerDelegate.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMessagePort.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTab.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTabCreationOptions.h:

Canonical link: https://commits.webkit.org/270067@main




More information about the webkit-changes mailing list