[webkit-changes] [WebKit/WebKit] 48bfdb: REGRESSION(267643 at main): wpt /css/css-properties-v...

Antti Koivisto noreply at github.com
Wed Nov 1 07:56:35 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 48bfdb7832dc5f3273dc1efd62561e575602a344
      https://github.com/WebKit/WebKit/commit/48bfdb7832dc5f3273dc1efd62561e575602a344
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-11-01 (Wed, 01 Nov 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-expected.txt
    M Source/WebCore/css/CSSCustomPropertyValue.cpp
    M Source/WebCore/css/CSSCustomPropertyValue.h

  Log Message:
  -----------
  REGRESSION(267643 at main): wpt /css/css-properties-values-api/var-reference-registered-properties.html
https://bugs.webkit.org/show_bug.cgi?id=263895
rdar://117690684

Reviewed by Alan Baradlay.

* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-expected.txt:
* Source/WebCore/css/CSSCustomPropertyValue.cpp:
(WebCore::CSSCustomPropertyValue::createEmpty):

Remove use of std::monostate as a way to indicate empty custom property value. Use a shared empty CSSVariableData instance instead.
This way we don't need special handling for the empty case.

(WebCore::CSSCustomPropertyValue::equals const):
(WebCore::CSSCustomPropertyValue::customCSSText const):
(WebCore::CSSCustomPropertyValue::tokens const):
* Source/WebCore/css/CSSCustomPropertyValue.h:

Canonical link: https://commits.webkit.org/270053@main




More information about the webkit-changes mailing list