[webkit-changes] [WebKit/WebKit] 376fed: [WebGPU] Compiler error opening https://kishimisu....

Tadeu Zagallo noreply at github.com
Wed Nov 1 03:19:29 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 376fed929bfa203c14af13362ebc352d34cb3852
      https://github.com/WebKit/WebKit/commit/376fed929bfa203c14af13362ebc352d34cb3852
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-11-01 (Wed, 01 Nov 2023)

  Changed paths:
    M Source/WebGPU/WGSL/TypeCheck.cpp
    M Source/WebGPU/WGSL/tests/valid/scope.wgsl

  Log Message:
  -----------
  [WebGPU] Compiler error opening https://kishimisu.github.io/WebGPU-Fluid-Simulation/
https://bugs.webkit.org/show_bug.cgi?id=263911
rdar://117698934

Reviewed by Mike Wyrzykowski.

When visiting the body of the if statement we were calling the base class' visitor,
which resulted in a missing scope for that block.

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/tests/valid/scope.wgsl:

Canonical link: https://commits.webkit.org/270047@main




More information about the webkit-changes mailing list