[webkit-changes] [WebKit/WebKit] 1a3a54: AX: Cache AXPropertyName::RelativeFrame for Access...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1a3a54995b6fceee8c5740ef52a424d3af000a1b
      https://github.com/WebKit/WebKit/commit/1a3a54995b6fceee8c5740ef52a424d3af000a1b
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-05-31 (Wed, 31 May 2023)

  Changed paths:
    M Source/WebCore/accessibility/AXGeometryManager.cpp
    M Source/WebCore/accessibility/AXGeometryManager.h
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/page/LocalFrameView.cpp
    M Source/WebCore/page/LocalFrameView.h
    M Source/WebCore/platform/ScrollableArea.h
    M Source/WebCore/platform/Scrollbar.cpp
    M Source/WebCore/platform/Scrollbar.h

  Log Message:
  -----------
  AX: Cache AXPropertyName::RelativeFrame for AccessibilityScrollbars
https://bugs.webkit.org/show_bug.cgi?id=257406
rdar://problem/109912633

Reviewed by Andres Gonzalez.

This patch also generalizes any reference to "paint" in AXGeometryManager
since we aren't relying on painting to update scrollbar geometry, and
the fact that the geometry for most types of objects is generated by
paint traversal is an implementation detail.

* Source/WebCore/accessibility/AXGeometryManager.cpp:
(WebCore::AXGeometryManager::cachedRectForID):
(WebCore::AXGeometryManager::cacheRect):
(WebCore::AXGeometryManager::paintRectForID): Deleted.
(WebCore::AXGeometryManager::onPaint): Deleted.
* Source/WebCore/accessibility/AXGeometryManager.h:
(WebCore::AXGeometryManager::remove):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::onScrollbarFrameRectChange):
(WebCore::AXObjectCache::onPaint const):
* Source/WebCore/accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::paintRectForID): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::scrollbarFrameRectChanged const):
* Source/WebCore/page/LocalFrameView.h:
* Source/WebCore/platform/ScrollableArea.h:
(WebCore::ScrollableArea::scrollbarFrameRectChanged const):
* Source/WebCore/platform/Scrollbar.cpp:
(WebCore::Scrollbar::Scrollbar):
(WebCore::Scrollbar::setFrameRect):
* Source/WebCore/platform/Scrollbar.h:

Canonical link: https://commits.webkit.org/264762@main