[webkit-changes] [WebKit/WebKit] 9add68: REGRESSION (264435 at main): Audio player time remain...
Tim Horton
noreply at github.com
Wed May 31 15:51:46 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9add6861de2a89ce6f9537d1dcd339b9829ac385
https://github.com/WebKit/WebKit/commit/9add6861de2a89ce6f9537d1dcd339b9829ac385
Author: Tim Horton <thorton at apple.com>
Date: 2023-05-31 (Wed, 31 May 2023)
Changed paths:
M Source/WebCore/Modules/modern-media-controls/controls/time-control.js
Log Message:
-----------
REGRESSION (264435 at main): Audio player time remainder/spent are oscillating when CSS width has been specified
https://bugs.webkit.org/show_bug.cgi?id=257523
rdar://110043258
Reviewed by Aditya Keerthi.
* Source/WebCore/Modules/modern-media-controls/controls/time-control.js:
(TimeControl.prototype._performIdealLayout):
When partially-reverting 264301 at main in 264435 at main, I re-introduced a
`this.elapsedTimeLabel.visible` which caused this flashing (because of a layout
dependency cycle). Since it is not relevant to the bug I was trying to fix
in 264435 at main, remove that condition and make this logic more like the
long-standing code.
Canonical link: https://commits.webkit.org/264760@main
More information about the webkit-changes
mailing list