[webkit-changes] [WebKit/WebKit] 80e4d7: [CSS] Resolve "currentcolor" with style if possible

Matthieu Dubet noreply at github.com
Wed May 31 09:48:52 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 80e4d733b9172fb72755d59424e5195944f1d416
      https://github.com/WebKit/WebKit/commit/80e4d733b9172fb72755d59424e5195944f1d416
  Author: Matthieu Dubet <m_dubet at apple.com>
  Date:   2023-05-31 (Wed, 31 May 2023)

  Changed paths:
    A LayoutTests/fast/css/color-mix-various-expected.html
    A LayoutTests/fast/css/color-mix-various.html
    M Source/WebCore/style/ColorFromPrimitiveValue.cpp
    M Source/WebCore/style/ElementRuleCollector.cpp

  Log Message:
  -----------
  [CSS] Resolve "currentcolor" with style if possible
https://bugs.webkit.org/show_bug.cgi?id=257255
rdar://108683501

Reviewed by Tim Nguyen.

Ideally, we should never try to resolve "currentcolor" during
style building.
However, for the rare cases where we do it (gradient, drop-shadow)
it's better to use the incomplete style than assuming an absolute color.

* LayoutTests/fast/css/color-mix-various-expected.html: Added.
* LayoutTests/fast/css/color-mix-various.html: Added.
* Source/WebCore/style/ColorFromPrimitiveValue.cpp:
(WebCore::Style::colorFromPrimitiveValueWithResolvedCurrentColor):
* Source/WebCore/style/ElementRuleCollector.cpp:
(WebCore::Style::ElementRuleCollector::addMatchedProperties):

Canonical link: https://commits.webkit.org/264737@main




More information about the webkit-changes mailing list