[webkit-changes] [WebKit/WebKit] fc1d86: [ iOS, macOS ] imported/w3c/web-platform-tests/web...

youennf noreply at github.com
Wed May 31 06:48:27 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fc1d86930378e691a495b9a6c6b74c6e3b534424
      https://github.com/WebKit/WebKit/commit/fc1d86930378e691a495b9a6c6b74c6e3b534424
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-05-31 (Wed, 31 May 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-frame-serialization.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-frame-serialization.any.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-construction.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-construction.any.worker-expected.txt
    M Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.cpp

  Log Message:
  -----------
  [ iOS, macOS ] imported/w3c/web-platform-tests/webcodecs/video-frame-serialization.any.html is a flaky text failure: A VideoFrame was destroyed without having been closed explicitly
https://bugs.webkit.org/show_bug.cgi?id=257354
rdar://109854552

Reviewed by Eric Carlson.

The test was flaky since we were failing an assert and not calling close().
We are updating VideoFrame.close() according spec which makes the test pass.
This will fix the flakiness.

* LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-frame-serialization.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-frame-serialization.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-construction.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-construction.any.worker-expected.txt:
* Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.cpp:
(WebCore::WebCodecsVideoFrame::close):

Canonical link: https://commits.webkit.org/264730@main




More information about the webkit-changes mailing list