[webkit-changes] [WebKit/WebKit] ea527f: Remove stripLeadingAndTrailingHTMLSpaces()

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ea527fa9c22d43cf4075f0364a6327a569a14a54
      https://github.com/WebKit/WebKit/commit/ea527fa9c22d43cf4075f0364a6327a569a14a54
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-05-30 (Tue, 30 May 2023)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/dom/DataTransfer.cpp
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/ScriptElement.cpp
    M Source/WebCore/dom/TextDecoder.cpp
    M Source/WebCore/html/EmailInputType.cpp
    M Source/WebCore/html/HTMLAnchorElement.cpp
    M Source/WebCore/html/HTMLBodyElement.cpp
    M Source/WebCore/html/HTMLEmbedElement.cpp
    M Source/WebCore/html/HTMLFrameElementBase.cpp
    M Source/WebCore/html/HTMLImageElement.cpp
    M Source/WebCore/html/HTMLImageLoader.cpp
    M Source/WebCore/html/HTMLObjectElement.cpp
    M Source/WebCore/html/HTMLOptionElement.cpp
    M Source/WebCore/html/HTMLTableElement.cpp
    M Source/WebCore/html/HTMLTablePartElement.cpp
    M Source/WebCore/html/HTMLVideoElement.cpp
    M Source/WebCore/html/URLInputType.cpp
    M Source/WebCore/html/parser/HTMLParserIdioms.cpp
    M Source/WebCore/html/parser/HTMLParserIdioms.h
    M Source/WebCore/loader/FormSubmission.cpp
    M Source/WebCore/loader/FrameLoader.cpp
    M Source/WebCore/loader/ImageLoader.cpp
    M Source/WebCore/page/csp/ContentSecurityPolicy.cpp
    M Source/WebCore/platform/ContentType.cpp
    M Source/WebCore/svg/SVGAElement.cpp
    M Source/WebCore/svg/SVGAnimationElement.cpp
    M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

  Log Message:
  -----------
  Remove stripLeadingAndTrailingHTMLSpaces()
https://bugs.webkit.org/show_bug.cgi?id=257414
rdar://109923008

Reviewed by Chris Dumez and Darin Adler.

Replace it with trim(isASCIIWhitespace),
isAllSpecialCharacters<isASCIIWhitespace<UChar>>, or remove it
altogether when the result is passed to WTF::protocolIsJavaScript() or
completeURL().

Also sprinkle a few FIXMEs around as we can probably do even better in
the future.

* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::invalidStatus const):
(WebCore::AccessibilityObject::currentState const):
(WebCore::AccessibilityObject::roleDescription const):
* Source/WebCore/dom/DataTransfer.cpp:
(WebCore::normalizeType):
(WebCore::DataTransfer::getDataForItem const):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::processBaseElement):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::attributeContainsJavaScriptURL const):
(WebCore::Element::getNonEmptyURLAttribute const):
* Source/WebCore/dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestClassicScript):
(WebCore::ScriptElement::requestModuleScript):
(WebCore::ScriptElement::requestImportMap):
(WebCore::ScriptElement::isScriptForEventSupported const):
* Source/WebCore/dom/TextDecoder.cpp:
(WebCore::TextDecoder::create):
* Source/WebCore/html/EmailInputType.cpp:
(WebCore::EmailInputType::typeMismatchFor const):
(WebCore::EmailInputType::sanitizeValue const):
* Source/WebCore/html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::attributeChanged):
(WebCore::HTMLAnchorElement::handleClick):
* Source/WebCore/html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::collectPresentationalHintsForAttribute):
* Source/WebCore/html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::attributeChanged):
* Source/WebCore/html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::attributeChanged):
(WebCore::HTMLFrameElementBase::setLocation):
* Source/WebCore/html/HTMLImageElement.cpp:
(WebCore::extractMIMETypeFromTypeAttributeForLookup):
* Source/WebCore/html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::sourceURI const):
* Source/WebCore/html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::attributeChanged):
(WebCore::HTMLObjectElement::parametersForPlugin):
* Source/WebCore/html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::text const):
(WebCore::HTMLOptionElement::value const):
(WebCore::HTMLOptionElement::label const):
(WebCore::HTMLOptionElement::displayLabel const):
* Source/WebCore/html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::collectPresentationalHintsForAttribute):
* Source/WebCore/html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::collectPresentationalHintsForAttribute):
* Source/WebCore/html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::imageSourceURL const):
(WebCore::HTMLVideoElement::posterImageURL const):
* Source/WebCore/html/URLInputType.cpp:
(WebCore::URLInputType::sanitizeValue const):
* Source/WebCore/html/parser/HTMLParserIdioms.cpp:
(WebCore::stripLeadingAndTrailingHTMLSpaces): Deleted.
* Source/WebCore/html/parser/HTMLParserIdioms.h:
* Source/WebCore/loader/FormSubmission.cpp:
(WebCore::FormSubmission::Attributes::parseAction):
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::extractContentLanguageFromHeader):
* Source/WebCore/loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::decode):
* Source/WebCore/page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowScriptWithNonce const):
(WebCore::ContentSecurityPolicy::allowStyleWithNonce const):
(WebCore::ContentSecurityPolicy::allowNonParserInsertedScripts const):
(WebCore::ContentSecurityPolicy::allowInlineScript const):
(WebCore::ContentSecurityPolicy::allowInlineStyle const):
(WebCore::ContentSecurityPolicy::allowScriptFromSource const):
(WebCore::ContentSecurityPolicy::allowStyleFromSource const):
* Source/WebCore/platform/ContentType.cpp:
(WebCore::ContentType::containerType const):
* Source/WebCore/svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler):
* Source/WebCore/svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::attributeContainsJavaScriptURL const):
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::performActionOnElement):

Canonical link: https://commits.webkit.org/264713@main