[webkit-changes] [WebKit/WebKit] 2def5f: AX: Implement unit testing of the functionality in...

AndresGonzalezApple noreply at github.com
Tue May 30 18:16:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2def5f3d4ef54a83a48285556e6d3ec67720a62e
      https://github.com/WebKit/WebKit/commit/2def5f3d4ef54a83a48285556e6d3ec67720a62e
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2023-05-30 (Tue, 30 May 2023)

  Changed paths:
    M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
    M Source/WebKit/WebProcess/WebProcess.h
    M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp
    M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm
    M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm

  Log Message:
  -----------
  AX: Implement unit testing of the functionality in NSApplicationAccessibilityFocusedUIElement.
https://bugs.webkit.org/show_bug.cgi?id=257377
<rdar://problem/109884868>

Reviewed by Darin Adler and Tyler Wilcock.

This function is the primary way in which MacOS AX clients determine the WebProcess focused object. This function is not exercised by any of the layout tests that manipulate and verify the focused element. To fix this, the following changes are made in this patch:
1. Added the static member function WebProcess::accessibilityFocusedUIElement that implements the functionality previously in NSApplicationAccessibilityFocusedUIElement.
2. NSApplicationAccessibilityFocusedUIElement now simply calls WebProcess::accessibilityFocusedUIElement.
3. Use WebProcess::accessibilityFocusedUIElement in the WKBundlePage C API WKAccessibilityFocusedObject so that it is usable from WTR::AccessibilityController.
4. Switch the AccessibilityController::focusedElement method to use WKAccessibilityFocusedObject instead of getting the focused element from the root element.
All calls to AccessibilityController::focusedElement will now use WebProcess::accessibilityFocusedUIElement. This change is MacOS only, iOS and other platforms are not affected.

Canonical link: https://commits.webkit.org/264706@main




More information about the webkit-changes mailing list