[webkit-changes] [WebKit/WebKit] 415cdc: [popover] Refactor all popover showing checks

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 415cdc82121c8d27beea7a1d5cfe3f543ee7c0fe
      https://github.com/WebKit/WebKit/commit/415cdc82121c8d27beea7a1d5cfe3f543ee7c0fe
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2023-05-30 (Tue, 30 May 2023)

  Changed paths:
    M Source/WebCore/css/SelectorCheckerTestFunctions.h
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/Element.h
    M Source/WebCore/dom/FullscreenManager.cpp
    M Source/WebCore/html/HTMLDialogElement.cpp
    M Source/WebCore/html/HTMLElement.cpp
    M Source/WebCore/page/FocusController.cpp

  Log Message:
  -----------
  [popover] Refactor all popover showing checks
https://bugs.webkit.org/show_bug.cgi?id=257428

Reviewed by Tim Nguyen.

Add a helper to test whether the popover is showing, which is
asked in quite a lot of places.

* Source/WebCore/css/SelectorCheckerTestFunctions.h:
(WebCore::matchesPopoverOpenPseudoClass):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::hideAllPopoversUntil):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::isPopoverShowing const):
* Source/WebCore/dom/Element.h:
* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::requestFullscreenForElement):
(WebCore::FullscreenManager::willEnterFullscreen):
(WebCore::isInPopoverShowingState): Deleted.
* Source/WebCore/html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::show):
(WebCore::HTMLDialogElement::showModal):
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::togglePopover):
(WebCore::HTMLElement::popoverAttributeChanged):
* Source/WebCore/page/FocusController.cpp:
(WebCore::isOpenPopoverWithInvoker):
(WebCore::invokerForPopoverShowingState):

Canonical link: https://commits.webkit.org/264693@main