[webkit-changes] [WebKit/WebKit] 883556: Web Inspector: XHR request with same URL as main r...

Yury Semikhatsky noreply at github.com
Tue May 30 11:38:06 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 883556d2265f71ae3ff0ba8c595936d7884192e7
      https://github.com/WebKit/WebKit/commit/883556d2265f71ae3ff0ba8c595936d7884192e7
  Author: Yury Semikhatsky <yurys at chromium.org>
  Date:   2023-05-30 (Tue, 30 May 2023)

  Changed paths:
    A LayoutTests/http/tests/inspector/network/xhr-request-type-expected.txt
    A LayoutTests/http/tests/inspector/network/xhr-request-type.html
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp

  Log Message:
  -----------
  Web Inspector: XHR request with same URL as main resource should have type XHR
https://bugs.webkit.org/show_bug.cgi?id=257407

Reviewed by Devin Rousso.

Only use cached resource type when couldn't infer resource type based on the current
ResourceRequest because CachedResource for the same URL may have different type. This
fixes the bug where XHR is sent with the same URL as the main resource and was
wrongly marked as another request with type Document rather than XHR.

* LayoutTests/http/tests/inspector/network/xhr-request-type-expected.txt: Added.
* LayoutTests/http/tests/inspector/network/xhr-request-type.html: Added.
* Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::willSendRequest):

* LayoutTests/platform/mac-wk1/TestExpectations: ignore new test in WK1.

Canonical link: https://commits.webkit.org/264686@main




More information about the webkit-changes mailing list