[webkit-changes] [WebKit/WebKit] 7bff5d: Implement scrollbar-gutter stable support for non-...

Luke Warlow noreply at github.com
Tue May 30 09:13:18 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7bff5db28e6c91a6daa904e04b6071ba3ba52276
      https://github.com/WebKit/WebKit/commit/7bff5db28e6c91a6daa904e04b6071ba3ba52276
  Author: Luke Warlow <luke at warlow.dev>
  Date:   2023-05-30 (Tue, 30 May 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-001-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-propagation-001-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-propagation-002-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-propagation-003-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-propagation-004-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-propagation-005-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-propagation-006-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-propagation-007-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-rtl-001-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-vertical-lr-001-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-vertical-rl-001-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-030-expected.txt
    M LayoutTests/platform/ios-wk2/TestExpectations
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderLayerScrollableArea.cpp

  Log Message:
  -----------
  Implement scrollbar-gutter stable support for non-viewport scrollables
https://bugs.webkit.org/show_bug.cgi?id=257453

Reviewed by Simon Fraser.

RenderLayerScrollableArea now returns the width a vertical scrollbar would be even if it doesn't exist
when a non auto scrollbar gutter is used.

This patch only works with horizontal writing modes, a follow up will address vertical writing modes.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-001-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-propagation-001-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-propagation-002-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-propagation-003-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-propagation-004-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-propagation-005-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-propagation-006-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-propagation-007-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-rtl-001-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-vertical-lr-001-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-vertical-rl-001-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-030-expected.txt:
* LayoutTests/platform/ios-wk2/TestExpectations:
* Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
(WebCore::RenderLayerScrollableArea::verticalScrollbarWidth const):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::includeVerticalScrollbarSize const):

Canonical link: https://commits.webkit.org/264677@main




More information about the webkit-changes mailing list