[webkit-changes] [WebKit/WebKit] 38e5d1: Correct return value in URLParser::defaultPortForP...

Anne van Kesteren noreply at github.com
Mon May 29 22:55:35 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 38e5d18210f94c26f20e4eae500015deef740081
      https://github.com/WebKit/WebKit/commit/38e5d18210f94c26f20e4eae500015deef740081
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-05-29 (Mon, 29 May 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_exclude=(file_javascript_mailto)-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/a-element_exclude=(file_javascript_mailto)-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/percent-encoding.window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/resources/percent-encoding.json
    M LayoutTests/imported/w3c/web-platform-tests/url/resources/urltestdata.json
    M LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_exclude=(file_javascript_mailto)-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_exclude=(file_javascript_mailto)-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt
    M Source/WTF/wtf/URLParser.cpp

  Log Message:
  -----------
  Correct return value in URLParser::defaultPortForProtocol()
https://bugs.webkit.org/show_bug.cgi?id=257441
rdar://109947586

Reviewed by Alex Christensen.

It returns an optional integer, not a boolean.

Tests for this specific case are exported via
https://github.com/web-platform-tests/wpt/pull/40278.

* LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_exclude=(file_javascript_mailto)-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/a-element_exclude=(file_javascript_mailto)-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/percent-encoding.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/resources/percent-encoding.json:
* LayoutTests/imported/w3c/web-platform-tests/url/resources/urltestdata.json:
* LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_exclude=(file_javascript_mailto)-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_exclude=(file_javascript_mailto)-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt:
* Source/WTF/wtf/URLParser.cpp:
(WTF::URLParser::defaultPortForProtocol):

Canonical link: https://commits.webkit.org/264661@main




More information about the webkit-changes mailing list