[webkit-changes] [WebKit/WebKit] 62e378: No need to trim whitespace before parsing as a URL

Anne van Kesteren noreply at github.com
Mon May 29 10:07:46 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 62e378d5047e24a0de8c2614906fdc5cc0ee010e
      https://github.com/WebKit/WebKit/commit/62e378d5047e24a0de8c2614906fdc5cc0ee010e
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-05-29 (Mon, 29 May 2023)

  Changed paths:
    M Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/editing/cocoa/HTMLConverter.mm
    M Source/WebCore/editing/gtk/EditorGtk.cpp
    M Source/WebCore/editing/ios/EditorIOS.mm
    M Source/WebCore/html/HTMLBaseElement.cpp
    M Source/WebCore/html/HTMLFormControlElement.cpp
    M Source/WebCore/html/HTMLFormElement.cpp
    M Source/WebCore/html/HTMLImageElement.cpp
    M Source/WebCore/html/parser/HTMLPreloadScanner.cpp
    M Source/WebCore/mathml/MathMLElement.cpp
    M Source/WebCore/page/DragController.cpp
    M Source/WebCore/rendering/HitTestResult.cpp
    M Source/WebCore/svg/SVGImageLoader.cpp
    M Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp
    M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
    M Source/WebKitLegacy/mac/DOM/DOM.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTML.mm
    M Source/WebKitLegacy/mac/DOM/WebDOMOperations.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm

  Log Message:
  -----------
  No need to trim whitespace before parsing as a URL
https://bugs.webkit.org/show_bug.cgi?id=257438
rdar://109939661

Reviewed by Michael Catanzaro and Alex Christensen.

The URL parser already trims all C0 controls and space code points.

* Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:
(WebCore::YouTubePluginReplacement::youTubeURL):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::absoluteLinkURL const):
* Source/WebCore/editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_addLinkForElement):
(HTMLConverter::_processElement):
* Source/WebCore/editing/gtk/EditorGtk.cpp:
(WebCore::Editor::writeImageToPasteboard):
* Source/WebCore/editing/ios/EditorIOS.mm:
(WebCore::Editor::writeImageToPasteboard):
* Source/WebCore/html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::href const):
* Source/WebCore/html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::formAction const):
* Source/WebCore/html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::action const):
* Source/WebCore/html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::isServerMap const):
* Source/WebCore/html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::updatePredictedBaseURL):
* Source/WebCore/mathml/MathMLElement.cpp:
(WebCore::MathMLElement::defaultEventHandler):
* Source/WebCore/page/DragController.cpp:
(WebCore::DragController::doSystemDrag):
* Source/WebCore/rendering/HitTestResult.cpp:
(WebCore::HitTestResult::absolutePDFURL const):
* Source/WebCore/svg/SVGImageLoader.cpp:
(WebCore::SVGImageLoader::sourceURI const):
* Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::openFunc):
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::elementPositionInformation):
(WebKit::WebPage::performActionOnElement):
* Source/WebKitLegacy/mac/DOM/DOM.mm:
(-[DOMNode hrefURL]):
(-[DOMElement _getURLAttribute:]):
* Source/WebKitLegacy/mac/DOM/DOMHTML.mm:
(-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
* Source/WebKitLegacy/mac/DOM/WebDOMOperations.mm:
(-[DOMDocument URLWithAttributeString:]):
* Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):

Canonical link: https://commits.webkit.org/264656@main




More information about the webkit-changes mailing list