[webkit-changes] [WebKit/WebKit] 153153: [GTK] Crash in GraphicsContextGLGBM::allocateDrawB...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 153153309cef73f2b65f8dfc3991044e705fe5a5
      https://github.com/WebKit/WebKit/commit/153153309cef73f2b65f8dfc3991044e705fe5a5
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2023-05-29 (Mon, 29 May 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.cpp
    M Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp

  Log Message:
  -----------
  [GTK] Crash in GraphicsContextGLGBM::allocateDrawBufferObject
https://bugs.webkit.org/show_bug.cgi?id=255398

Reviewed by Michael Catanzaro.

GBMBufferSwapchain::getBuffer() can return nullptr for several reasons,
so we need to handle that case in
GraphicsContextGLGBM::allocateDrawBufferObject(). This also adds error
messages for the cases where getBuffer() returns nullptr, and returns
earlier without creating any buffer when the given format is
unsupported.

* Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.cpp:
(WebCore::isBufferFormatSupported):
(WebCore::GBMBufferSwapchain::getBuffer):
* Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp:
(WebCore::GraphicsContextGLGBM::allocateDrawBufferObject):

Canonical link: https://commits.webkit.org/264648@main