[webkit-changes] [WebKit/WebKit] 435dd7: [GTK] Layout Test media/video-seek-with-negative-p...

Philippe Normand noreply at github.com
Mon May 29 00:47:45 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 435dd73cccb588f8caf5fba1ef4f59b63c843dbc
      https://github.com/WebKit/WebKit/commit/435dd73cccb588f8caf5fba1ef4f59b63c843dbc
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-05-29 (Mon, 29 May 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

  Log Message:
  -----------
  [GTK] Layout Test media/video-seek-with-negative-playback.html timeouts on the release bot.
https://bugs.webkit.org/show_bug.cgi?id=135086
<rdar://problem/85258014>

Reviewed by Xabier Rodriguez-Calvar.

The test was flaky timeout because sometimes the seek updating the playback rate was done before any
of the sinks had reported a non-zero playback position. So we ended up doing a seek with both
`start` and `end` positions set to zero, leading to a stall, no `timeupdate` event dispatched, hence
test timing out.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::doSeek):

Canonical link: https://commits.webkit.org/264646@main




More information about the webkit-changes mailing list