[webkit-changes] [WebKit/WebKit] 875ce9: WKWebViewConfiguration._delaysWebProcessLaunchUnti...

Chris Dumez noreply at github.com
Fri May 26 16:18:20 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 875ce9b4924519fdd54e7d12818290bfe5e2dec9
      https://github.com/WebKit/WebKit/commit/875ce9b4924519fdd54e7d12818290bfe5e2dec9
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-05-26 (Fri, 26 May 2023)

  Changed paths:
    M Source/WebKit/UIProcess/API/APIPageConfiguration.cpp
    M Source/WebKit/UIProcess/API/APIPageConfiguration.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm

  Log Message:
  -----------
  WKWebViewConfiguration._delaysWebProcessLaunchUntilFirstLoad SPI is not working
https://bugs.webkit.org/show_bug.cgi?id=257391
rdar://109904914

Reviewed by Ben Nham.

The WKWebViewConfiguration._delaysWebProcessLaunchUntilFirstLoad SPI was not working
because we were failing to copy the flag over in API::PageConfiguration::copy().

The unit tests didn't catch it because they weren't waiting long enough to see if
a process had launched. I am fixing this too.

I am also adding more logging to help with debugging.

* Source/WebKit/UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::copy const):
(API::PageConfiguration::setDelaysWebProcessLaunchUntilFirstLoad):
(API::PageConfiguration::delaysWebProcessLaunchUntilFirstLoad const):
* Source/WebKit/UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::setDelaysWebProcessLaunchUntilFirstLoad): Deleted.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

Canonical link: https://commits.webkit.org/264609@main




More information about the webkit-changes mailing list