[webkit-changes] [WebKit/WebKit] 5f43fe: REGRESSION(262981 at main): [iOS] WebKit never activa...

Jer Noble noreply at github.com
Fri May 26 12:21:18 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5f43fea0e5c1c638c3dbbdafb73298c5066f0fde
      https://github.com/WebKit/WebKit/commit/5f43fea0e5c1c638c3dbbdafb73298c5066f0fde
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-05-26 (Fri, 26 May 2023)

  Changed paths:
    M Source/WebCore/platform/audio/ios/AudioSessionIOS.h

  Log Message:
  -----------
  REGRESSION(262981 at main): [iOS] WebKit never activates its AVAudioSession
https://bugs.webkit.org/show_bug.cgi?id=257309
rdar://109817291

Reviewed by Eric Carlson and Youenn Fablet.

In 262981 at main, the contents of AudioSessionIOS::tryToSetActiveInternal() were moved into
a new common base class of AudioSessionIOS and AudioSessionMac: AudioSessionCocoa.

However, that patch neglected to make AudioSessionCocoa a base class of AudioSessionIOS.
This had the effect of removing audio session activation entirely from the iOS port of
WebKit.

* Source/WebCore/platform/audio/ios/AudioSessionIOS.h:

Canonical link: https://commits.webkit.org/264599@main




More information about the webkit-changes mailing list