[webkit-changes] [WebKit/WebKit] 5a0dc0: Remove duplicate DNS lookup implementation

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a0dc0c7e3a5b1d90ad25e7901711012c173e4e4
      https://github.com/WebKit/WebKit/commit/5a0dc0c7e3a5b1d90ad25e7901711012c173e4e4
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-05-26 (Fri, 26 May 2023)

  Changed paths:
    M Source/WebCore/platform/network/DNS.cpp
    M Source/WebCore/platform/network/DNS.h
    M Source/WebCore/platform/network/DNSResolveQueue.h
    M Source/WebCore/platform/network/cf/DNSResolveQueueCFNet.cpp
    M Source/WebCore/platform/network/cf/DNSResolveQueueCFNet.h
    M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp
    M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h
    R Source/WebKit/NetworkProcess/webrtc/NetworkRTCResolver.cpp
    R Source/WebKit/NetworkProcess/webrtc/NetworkRTCResolver.h
    R Source/WebKit/NetworkProcess/webrtc/NetworkRTCResolverCocoa.cpp
    R Source/WebKit/NetworkProcess/webrtc/NetworkRTCResolverCocoa.h
    M Source/WebKit/SourcesCocoa.txt
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Remove duplicate DNS lookup implementation
https://bugs.webkit.org/show_bug.cgi?id=257303
rdar://109812699

Reviewed by Youenn Fablet.

DNSServiceGetAddrInfo is the replacement for CFHostStartInfoResolution.

Remove NetworkRTCResolver in favor of implementing DNSResolveQueueCFNet::resolve
like the libSoup ports and sharing 1 implementation instead of having duplicate code.

* Source/WebCore/platform/network/DNS.cpp:
(WebCore::resolveDNS):
* Source/WebCore/platform/network/DNS.h:
(WebCore::IPAddress::fromSockAddrIn6): Deleted.
* Source/WebCore/platform/network/DNSResolveQueue.h:
* Source/WebCore/platform/network/cf/DNSResolveQueueCFNet.cpp:
(WebCore::DNSResolveQueueCFNet::CompletionHandlerWrapper::create):
(WebCore::DNSResolveQueueCFNet::CompletionHandlerWrapper::complete):
(WebCore::DNSResolveQueueCFNet::CompletionHandlerWrapper::addIPAddress):
(WebCore::DNSResolveQueueCFNet::CompletionHandlerWrapper::CompletionHandlerWrapper):
(WebCore::extractIPAddress):
(WebCore::dnsLookupCallback):
(WebCore::DNSResolveQueueCFNet::performDNSLookup):
(WebCore::DNSResolveQueueCFNet::platformResolve):
(WebCore::DNSResolveQueueCFNet::resolve):
(WebCore::DNSResolveQueueCFNet::stopResolve):
(WebCore::clientCallback): Deleted.
* Source/WebCore/platform/network/cf/DNSResolveQueueCFNet.h:
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::close):
(WebKit::NetworkRTCProvider::createResolver):
(WebKit::NetworkRTCProvider::stopResolver):
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h:
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCResolver.cpp: Removed.
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCResolver.h: Removed.
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCResolverCocoa.cpp: Removed.
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCResolverCocoa.h: Removed.
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/264586@main