[webkit-changes] [WebKit/WebKit] 835136: SVGTextLayoutEngine m_textPathStartOffset is unini...

[Nikolas Zimmermann]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 835136aa12f7848edb9abdc3e8d0d11500172ad2
      https://github.com/WebKit/WebKit/commit/835136aa12f7848edb9abdc3e8d0d11500172ad2
  Author: Nikolas Zimmermann <nzimmermann at igalia.com>
  Date:   2023-05-26 (Fri, 26 May 2023)

  Changed paths:
    M Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp
    M Source/WebCore/rendering/svg/SVGTextLayoutEngine.h

  Log Message:
  -----------
  SVGTextLayoutEngine m_textPathStartOffset is uninitialized
https://bugs.webkit.org/show_bug.cgi?id=257156

Reviewed by Rob Buis.

Initialize all SVGTextLayoutEngine members using brace initializaation
in the header, to avoid uninitialized variables, like m_textPathStartOffset.

It has no practical consequences, as it's always set before entering
path-layout mode - however we should clean it up to avoid this in future.

Covered by existing tests.

* Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::SVGTextLayoutEngine):
* Source/WebCore/rendering/svg/SVGTextLayoutEngine.h:

Canonical link: https://commits.webkit.org/264580@main