[webkit-changes] [WebKit/WebKit] db590b: [WGSL] Cache reference types

Tadeu Zagallo noreply at github.com
Fri May 26 02:08:31 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: db590b8161a90b781e6d6e84c200046c47683bd8
      https://github.com/WebKit/WebKit/commit/db590b8161a90b781e6d6e84c200046c47683bd8
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-05-26 (Fri, 26 May 2023)

  Changed paths:
    M Source/WebGPU/WGSL/TypeStore.cpp

  Log Message:
  -----------
  [WGSL] Cache reference types
https://bugs.webkit.org/show_bug.cgi?id=257329
rdar://109834367

Reviewed by Mike Wyrzykowski.

It was unclear at first if reference types needed to be cached, but considering
we allocate a new reference type for every var, plus some more during compilation,
it seems like a good idea to use our last available byte in the key encoding to
cache them.

* Source/WebGPU/WGSL/TypeStore.cpp:
(WGSL::ReferenceKey::extra const):
(WGSL::TypeStore::referenceType):

Canonical link: https://commits.webkit.org/264572@main




More information about the webkit-changes mailing list