[webkit-changes] [WebKit/WebKit] d9674f: [WGSL] Type checker should use reference type for ...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d9674fd1aa78109239d952c2f20f1c2fc402947a
      https://github.com/WebKit/WebKit/commit/d9674fd1aa78109239d952c2f20f1c2fc402947a
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-05-26 (Fri, 26 May 2023)

  Changed paths:
    M Source/WebGPU/WGSL/Constraints.cpp
    M Source/WebGPU/WGSL/Overload.cpp
    M Source/WebGPU/WGSL/TypeCheck.cpp
    M Source/WebGPU/WGSL/Types.cpp
    M Source/WebGPU/WGSL/tests/invalid/for.wgsl
    M Source/WebGPU/WGSL/tests/invalid/overload.wgsl
    A Source/WebGPU/WGSL/tests/invalid/references.wgsl
    A Source/WebGPU/WGSL/tests/valid/references.wgsl

  Log Message:
  -----------
  [WGSL] Type checker should use reference type for var references
https://bugs.webkit.org/show_bug.cgi?id=257272
rdar://109787826

Reviewed by Mike Wyrzykowski.

When we have a declaration `var x: T`, any identifier `x` in the program that
refer to this declaration should have type `ref<T>` instead of `T`. To keep
everything working it was necessary to implement field access and index access
over references as well as handle references in the overload resolution.

* Source/WebGPU/WGSL/Constraints.cpp:
(WGSL::satisfies):
(WGSL::satisfyOrPromote):
* Source/WebGPU/WGSL/Overload.cpp:
(WGSL::OverloadResolver::calculateRank):
(WGSL::OverloadResolver::unify):
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::check):
(WGSL::TypeChecker::visit):
(WGSL::TypeChecker::visitVariable):
(WGSL::TypeChecker::vectorFieldAccess):
(WGSL::TypeChecker::isBottom const):
* Source/WebGPU/WGSL/Types.cpp:
(WGSL::conversionRank):
* Source/WebGPU/WGSL/tests/invalid/for.wgsl:
* Source/WebGPU/WGSL/tests/invalid/overload.wgsl:
* Source/WebGPU/WGSL/tests/invalid/references.wgsl: Added.
* Source/WebGPU/WGSL/tests/valid/references.wgsl: Added.

Canonical link: https://commits.webkit.org/264570@main