[webkit-changes] [WebKit/WebKit] c60b4c: REGRESSION(2.41): [GTK] Contents not rendered in n...

Carlos Garcia Campos noreply at github.com
Thu May 25 22:24:24 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c60b4c7731a11cedf8448eaf758229fd391be42b
      https://github.com/WebKit/WebKit/commit/c60b4c7731a11cedf8448eaf758229fd391be42b
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2023-05-25 (Thu, 25 May 2023)

  Changed paths:
    M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp
    M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.h

  Log Message:
  -----------
  REGRESSION(2.41): [GTK] Contents not rendered in new web view when realized after configure and frame
https://bugs.webkit.org/show_bug.cgi?id=257324

Reviewed by Michael Catanzaro.

In case of realize happening after the configure and frame, we create a
committed source, but it's not ready for rendering. This patch splits
the swap method into swap and prepareForRendering. When a new frame is
available we always do swap, to be in sync with the web process, but only
prepareForRendering when view is realized. When realize happens after the
configure and frame we only need to call prepareForRendering().

* Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp:
(WebKit::AcceleratedBackingStoreDMABuf::Texture::~Texture):
(WebKit::AcceleratedBackingStoreDMABuf::Texture::swap):
(WebKit::AcceleratedBackingStoreDMABuf::Surface::map const):
(WebKit::AcceleratedBackingStoreDMABuf::Surface::swap):
(WebKit::AcceleratedBackingStoreDMABuf::Surface::prepareForRendering):
(WebKit::AcceleratedBackingStoreDMABuf::frame):
(WebKit::AcceleratedBackingStoreDMABuf::realize):
* Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.h:

Canonical link: https://commits.webkit.org/264558@main




More information about the webkit-changes mailing list