[webkit-changes] [WebKit/WebKit] ad0f3b: Fix crash in WebCore::ManagedMediaSource::isOpen()

Chirag Shah noreply at github.com
Thu May 25 19:58:07 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ad0f3bf368a6e3a0a20eb9ec7f94da2fdf343d49
      https://github.com/WebKit/WebKit/commit/ad0f3bf368a6e3a0a20eb9ec7f94da2fdf343d49
  Author: Chirag M Shah <chirag_m_shah at apple.com>
  Date:   2023-05-25 (Thu, 25 May 2023)

  Changed paths:
    A LayoutTests/fast/media/managed-media-source-open-crash-expected.txt
    A LayoutTests/fast/media/managed-media-source-open-crash.html
    M Source/WebCore/Modules/mediasource/ManagedMediaSource.cpp

  Log Message:
  -----------
  Fix crash in WebCore::ManagedMediaSource::isOpen()
https://bugs.webkit.org/show_bug.cgi?id=257345
rdar://109827653

Reviewed by Jer Noble.

mediaElement() might have gone away when we're checking for
ManagedMediaSource::isOpen(), which can cause a crash. This change fixes
that.

* Source/WebCore/Modules/mediasource/ManagedMediaSource.cpp:
(WebCore::ManagedMediaSource::ensurePrefsRead):
(WebCore::ManagedMediaSource::isOpen const):
* LayoutTests/fast/media/managed-media-source-open-crash-expected.txt: Added.
* LayoutTests/fast/media/managed-media-source-open-crash.html: Added.

Canonical link: https://commits.webkit.org/264554@main




More information about the webkit-changes mailing list