[webkit-changes] [WebKit/WebKit] abdeae: JavaScriptCore InstallAPI includes broken path to ...

Elliott Williams noreply at github.com
Thu May 25 19:31:54 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: abdeae2f7a0890115899dc3876bd6dad1f60cadb
      https://github.com/WebKit/WebKit/commit/abdeae2f7a0890115899dc3876bd6dad1f60cadb
  Author: Elliott Williams <emw at apple.com>
  Date:   2023-05-25 (Thu, 25 May 2023)

  Changed paths:
    M Source/WTF/Configurations/WTF.xcconfig

  Log Message:
  -----------
  JavaScriptCore InstallAPI includes broken path to unicode headers on open-source builds
https://bugs.webkit.org/show_bug.cgi?id=256810

Reviewed by Alexey Proskuryakov.

In open-source builds, the tapi filelist generated by WTF contains broken paths
to ICU headers. This is because all-product-headers.yaml contains references to
*all* the headers in WTF.xcodeproj, despite being generated for a specific
target.

Fix by setting EXCLUDED_SOURCE_FILE_NAMES in the WTF target to always exclude
icu headers. The headers are members of the separate "icu" target already, so
their installation is unaffected. I think this setting is a holdover from when
there was a single target in the WTF project.

* Source/WTF/Configurations/WTF.xcconfig:

Canonical link: https://commits.webkit.org/264550@main




More information about the webkit-changes mailing list