[webkit-changes] [WebKit/WebKit] 50a648: CompletionHandler assertions fire when navigating ...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 50a6489ac823965b7f7aa40c32b3ed0b39a1168c
      https://github.com/WebKit/WebKit/commit/50a6489ac823965b7f7aa40c32b3ed0b39a1168c
  Author: Tim Horton <thorton at apple.com>
  Date:   2023-05-25 (Thu, 25 May 2023)

  Changed paths:
    M Source/WebCore/loader/ios/LegacyPreviewLoader.h
    M Source/WebCore/loader/ios/LegacyPreviewLoader.mm
    M Source/WebCore/platform/PreviewConverterProvider.h

  Log Message:
  -----------
  CompletionHandler assertions fire when navigating away from a QuickLook password field
https://bugs.webkit.org/show_bug.cgi?id=257342
rdar://109847525

Reviewed by Wenson Hsieh.

* Source/WebCore/loader/ios/LegacyPreviewLoader.h:
* Source/WebCore/loader/ios/LegacyPreviewLoader.mm:
(WebCore::LegacyPreviewLoader::providePasswordForPreviewConverter):
* Source/WebCore/platform/PreviewConverterProvider.h:
Convert the argument to `providePasswordForPreviewConverter`
from a CompletionHandler to a plain old function, because it doesn't fulfull
any of the CompletionHandler invariants:

- it can be never called, if you navigate away without entering a password
- it can be called multiple times, if you get the password wrong and try again

Canonical link: https://commits.webkit.org/264537@main