[webkit-changes] [WebKit/WebKit] 2434c2: Change event isn't firing when the user reverts th...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2434c2b49b9956110d55edfa28a42ceef2776972
      https://github.com/WebKit/WebKit/commit/2434c2b49b9956110d55edfa28a42ceef2776972
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-05-25 (Thu, 25 May 2023)

  Changed paths:
    A LayoutTests/fast/forms/date/date-editable-components/date-multiple-fields-choose-default-value-after-set-value-expected.txt
    A LayoutTests/fast/forms/date/date-editable-components/date-multiple-fields-choose-default-value-after-set-value.html
    A LayoutTests/fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-multiple-fields-choose-default-value-after-set-value-expected.txt
    A LayoutTests/fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-multiple-fields-choose-default-value-after-set-value.html
    A LayoutTests/fast/forms/time/time-editable-components/time-multiple-fields-choose-default-value-after-set-value-expected.txt
    A LayoutTests/fast/forms/time/time-editable-components/time-multiple-fields-choose-default-value-after-set-value.html
    M Source/WebCore/html/HTMLInputElement.cpp
    M Source/WebCore/html/TextFieldInputType.cpp

  Log Message:
  -----------
  Change event isn't firing when the user reverts the value of color/date/time/datetime input after JS changed the value

https://bugs.webkit.org/show_bug.cgi?id=121590

Reviewed by Aditya Keerthi.

Partial Merge: https://chromium.googlesource.com/chromium/blink/+/3054068c08635caf65eb933794f5ac6bbaf80e23

NOTE: We are not merging 'Color' input test due to lack of test infrastructure support.

Setting the value through the value property wasn't setting the textAsOfLastFormControlChangeEvent.
So change events weren't firing when the user changes the value
back to the one that was set before JS changed it.

* Source/WebCore/html/HTMLInputElement.cpp:
(HTMLInputElement::setValue) - Add if condition to add "santantizedValue" for setTextAsOfLastFormControlChangeEvent
* Source/WebCore/html/TextFieldInput.cpp:
(TextFieldIputType::setValue) - Remove FIXME and condition of eventBehavior being DispatchNoEvent
* LayoutTests/fast/forms/time/time-editable-components/time-multiple-fields-choose-default-value-after-set-value.html: Add Test Case
* LayoutTests/fast/forms/time/time-editable-components/time-multiple-fields-choose-default-value-after-set-value-expected.txt: Add Test Case Expectation
* LayoutTests/fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-multiple-fields-choose-default-value-after-set-value.html: Add Test Case
* LayoutTests/fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-multiple-fields-choose-default-value-after-set-value-expected.txt: Add Test Case Expectation
* LayoutTests/fast/forms/date/date-editable-components/date-multiple-fields-choose-default-value-after-set-value.html: Add Test Case
* LayoutTests/fast/forms/date/date-editable-components/date-multiple-fields-choose-default-value-after-set-value-expected.txt: Add Test Case Expectation

Canonical link: https://commits.webkit.org/264528@main