[webkit-changes] [WebKit/WebKit] c51eba: Move CSS text-wrap property to m_inheritedFlags
Commit Queue
noreply at github.com
Thu May 25 10:25:26 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c51eba8aa0097aea61324b0f927871669e306484
https://github.com/WebKit/WebKit/commit/c51eba8aa0097aea61324b0f927871669e306484
Author: David Choi <david_choi5 at apple.com>
Date: 2023-05-25 (Thu, 25 May 2023)
Changed paths:
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleInlines.h
M Source/WebCore/rendering/style/RenderStyleSetters.h
M Source/WebCore/rendering/style/StyleRareInheritedData.cpp
M Source/WebCore/rendering/style/StyleRareInheritedData.h
Log Message:
-----------
Move CSS text-wrap property to m_inheritedFlags
https://bugs.webkit.org/show_bug.cgi?id=257237
rdar://109743940
Reviewed by Tim Nguyen.
CSS text-wrap is placed inside m_rareInheritedData. Since text-wrap
is a longhand property of white-space, which is frequently set, the
text-wrap property should really reside in either m_inheritedData or
m_inheritedFlags. Given that the possible range of values of text-wrap
can be encoded in 3 bits, m_inheritedFlags is preferable to
m_inheritedData.
* Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::textWrap const):
(WebCore::RenderStyle::setTextWrap):
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::textUnderlinePosition const):
(WebCore::RenderStyle::InheritedFlags::operator== const):
(WebCore::RenderStyle::textWrap const): Deleted.
* Source/WebCore/rendering/style/RenderStyleSetters.h:
(WebCore::RenderStyle::setTextUnderlinePosition):
(WebCore::RenderStyle::setTextWrap): Deleted.
* Source/WebCore/rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):
* Source/WebCore/rendering/style/StyleRareInheritedData.h:
Canonical link: https://commits.webkit.org/264523@main
More information about the webkit-changes
mailing list