[webkit-changes] [WebKit/WebKit] 750b57: RemoteScrollingCoordinator::scheduleTreeStateCommi...

mattwoodrow noreply at github.com
Wed May 24 21:40:38 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 750b577cdf3f464b7fdde8fac2f570c173597c0a
      https://github.com/WebKit/WebKit/commit/750b577cdf3f464b7fdde8fac2f570c173597c0a
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2023-05-24 (Wed, 24 May 2023)

  Changed paths:
    M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm

  Log Message:
  -----------
  RemoteScrollingCoordinator::scheduleTreeStateCommit() can result in extra rendering updates
https://bugs.webkit.org/show_bug.cgi?id=244276
<rdar://problem/99353273>

Reviewed by Simon Fraser.

RemoteScrollingCoordinator::scheduleTreeStateCommit() can be called in the middle of a compositing update.

Instead of just handling that scrolling tree commit in the current update (which is what would happen if it called into Page::scheduleRenderingUpdate()), it triggers another update after the current one, because it just calls the WebKit2-level drawingArea()->triggerRenderingUpdate().

* Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h:
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm:
(WebKit::RemoteScrollingCoordinator::scheduleTreeStateCommit):

Canonical link: https://commits.webkit.org/264503@main




More information about the webkit-changes mailing list