[webkit-changes] [WebKit/WebKit] c8996a: [css-flexbox] Rename LineContext to LineState.

Sammy Gill noreply at github.com
Wed May 24 18:50:12 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c8996adb70693fd8248900697852545a7a9539d9
      https://github.com/WebKit/WebKit/commit/c8996adb70693fd8248900697852545a7a9539d9
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2023-05-24 (Wed, 24 May 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderFlexibleBox.cpp
    M Source/WebCore/rendering/RenderFlexibleBox.h

  Log Message:
  -----------
  [css-flexbox] Rename LineContext to LineState.
https://bugs.webkit.org/show_bug.cgi?id=257225
rdar://109738350

Reviewed by Alan Baradlay.

LineState is a slightly better name in the flex layout code here
since there are various points at which we are modifying it and
"context," seems to imply some level of immutability.

* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::LineState::LineState):
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignFlexLines):
(WebCore::RenderFlexibleBox::alignChildren):
(WebCore::RenderFlexibleBox::flipForRightToLeftColumn):
(WebCore::RenderFlexibleBox::flipForWrapReverse):
(WebCore::RenderFlexibleBox::LineContext::LineContext): Deleted.
* Source/WebCore/rendering/RenderFlexibleBox.h:

Canonical link: https://commits.webkit.org/264500@main




More information about the webkit-changes mailing list